Skip to content

Commit

Permalink
fix
Browse files Browse the repository at this point in the history
  • Loading branch information
MacHu-GWU committed Mar 24, 2023
1 parent 6980d73 commit 6a323f0
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 2 deletions.
3 changes: 3 additions & 0 deletions README.rst
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,9 @@
.. image:: https://img.shields.io/pypi/v/boto_session_manager.svg
:target: https://pypi.python.org/pypi/boto_session_manager

.. image:: https://img.shields.io/pypi/l/boto_session_manager.svg
:target: https://pypi.python.org/pypi/boto_session_manager

.. image:: https://img.shields.io/pypi/pyversions/boto_session_manager.svg
:target: https://pypi.python.org/pypi/boto_session_manager

Expand Down
6 changes: 4 additions & 2 deletions tests/test_manager.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,13 +9,15 @@
from boto_session_manager.manager import BotoSesManager, AwsServiceEnum

if "CI" in os.environ: # pragma: no cover
is_ci = True
aws_access_key_id = os.environ["AWS_ACCESS_KEY_ID_FOR_GITHUB_CI"]
aws_secret_access_key = os.environ["AWS_SECRET_ACCESS_KEY_FOR_GITHUB_CI"]
bsm = BotoSesManager(
aws_access_key_id=aws_access_key_id,
aws_secret_access_key=aws_secret_access_key,
)
else: # pragma: no cover
is_ci = False
profile_name = "aws_data_lab_open_source_boto_session_manager"
bsm = BotoSesManager(profile_name=profile_name)

Expand Down Expand Up @@ -94,8 +96,8 @@ def _assert_default_aws_cli_credential_is_different(self, bsm: BotoSesManager):
self._assert_aws_cli_env_var_not_exists()

@pytest.mark.skipif(
sys.platform.startswith("win"),
reason="windows CLI system is different",
is_ci,
reason="we don't want to expose real AWS credentials in CI",
)
def test_cli_context_manager_with_arguments(self):
# the bsm object is using the profile "aws_data_lab_open_source_boto_session_manager"
Expand Down

0 comments on commit 6a323f0

Please sign in to comment.