Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added lab for AWS CloudFormation Guard. #135

Merged
merged 7 commits into from
Dec 13, 2021
Merged

Added lab for AWS CloudFormation Guard. #135

merged 7 commits into from
Dec 13, 2021

Conversation

mrinaudo-aws
Copy link
Contributor

Issue #, if available:

Description of changes:
Added lab for AWS CloudFormation Guard.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@rezabekf
Copy link
Contributor

rezabekf commented Dec 9, 2021

It seems there is no code in solutions directory ? Could you add that please?

@mrinaudo-aws
Copy link
Contributor Author

It seems there is no code in solutions directory ? Could you add that please?

I just did, and temporarily commented out lines in the pre-commit file as the yaml test file for example Guard rules is not a CloudFormation template (both cfn-lint and rain yielded errors). I will restore the previous file content now - may I suggest we consider a permanent solution for this, i.e., an exclusion path/pattern if possible?

@rezabekf
Copy link
Contributor

rezabekf commented Dec 9, 2021

It seems there is no code in solutions directory ? Could you add that please?

I just did, and temporarily commented out lines in the pre-commit file as the yaml test file for example Guard rules is not a CloudFormation template (both cfn-lint and rain yielded errors). I will restore the previous file content now - may I suggest we consider a permanent solution for this, i.e., an exclusion path/pattern if possible?

All fixed

@mrinaudo-aws
Updated example template in the workspace directory to match the form…
847715a 
…at of the file in the solutions directory.
@mrinaudo-aws
Updated descriptions for templates, removed comments from files in th…
1df6d16 
…e solutions directory, left/readded comments in workspace files.
stilvoid
stilvoid reviewed Dec 13, 2021
View reviewed changes
Copy link
Member

@stilvoid stilvoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments but otherwise lgtm

.github/workflows/unit-tests.yaml Show resolved Hide resolved
.pre-commit-config.yaml Show resolved Hide resolved
rezabekf
rezabekf approved these changes Dec 13, 2021
View reviewed changes
Copy link
Contributor

@rezabekf rezabekf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT

stilvoid
stilvoid approved these changes Dec 13, 2021
View reviewed changes
Copy link
Member

@stilvoid stilvoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@stilvoid stilvoid mentioned this pull request Dec 13, 2021
Closed
@stilvoid stilvoid merged commit 1b50b93 into main Dec 13, 2021
@stilvoid stilvoid deleted the mrinaudo-aws/policy-as-code-with-guard branch December 13, 2021 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stilvoid stilvoid stilvoid approved these changes

@rezabekf rezabekf rezabekf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mrinaudo-aws @rezabekf @stilvoid