Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kumarev/update behaviors of stack resources #154

Merged
merged 38 commits into from
Mar 3, 2022

Conversation

kumarev
Copy link
Contributor

@kumarev kumarev commented Feb 25, 2022

update behaviors of stack resources:

Workshop content for 'update behaviors of stack resources'

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Contributor

@mrinaudo-aws mrinaudo-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @kumarev ! Please review/approve suggestions, and ask for another review!

kumarev and others added 22 commits March 1, 2022 14:56
…tack-resources/_index.md

Co-authored-by: Matteo Rinaudo <52245107+mrinaudo-aws@users.noreply.github.com>
…tack-resources/_index.md

Co-authored-by: Matteo Rinaudo <52245107+mrinaudo-aws@users.noreply.github.com>
…tack-resources/_index.md

Co-authored-by: Matteo Rinaudo <52245107+mrinaudo-aws@users.noreply.github.com>
…tack-resources/_index.md

Co-authored-by: Matteo Rinaudo <52245107+mrinaudo-aws@users.noreply.github.com>
…tack-resources/_index.md

Co-authored-by: Matteo Rinaudo <52245107+mrinaudo-aws@users.noreply.github.com>
…tack-resources/_index.md

Co-authored-by: Matteo Rinaudo <52245107+mrinaudo-aws@users.noreply.github.com>
…tack-resources/_index.md

Co-authored-by: Matteo Rinaudo <52245107+mrinaudo-aws@users.noreply.github.com>
…tack-resources/_index.md

Co-authored-by: Matteo Rinaudo <52245107+mrinaudo-aws@users.noreply.github.com>
…tack-resources/_index.md

Co-authored-by: Matteo Rinaudo <52245107+mrinaudo-aws@users.noreply.github.com>
…tack-resources/_index.md

Co-authored-by: Matteo Rinaudo <52245107+mrinaudo-aws@users.noreply.github.com>
…tack-resources/_index.md

Co-authored-by: Matteo Rinaudo <52245107+mrinaudo-aws@users.noreply.github.com>
…tack-resources/_index.md

Co-authored-by: Matteo Rinaudo <52245107+mrinaudo-aws@users.noreply.github.com>
…tack-resources/_index.md

Co-authored-by: Matteo Rinaudo <52245107+mrinaudo-aws@users.noreply.github.com>
…tack-resources/_index.md

Co-authored-by: Matteo Rinaudo <52245107+mrinaudo-aws@users.noreply.github.com>
…tack-resources/_index.md

Co-authored-by: Matteo Rinaudo <52245107+mrinaudo-aws@users.noreply.github.com>
…tack-resources/_index.md

Co-authored-by: Matteo Rinaudo <52245107+mrinaudo-aws@users.noreply.github.com>
…tack-resources/_index.md

Co-authored-by: Matteo Rinaudo <52245107+mrinaudo-aws@users.noreply.github.com>
…tack-resources/_index.md

Co-authored-by: Matteo Rinaudo <52245107+mrinaudo-aws@users.noreply.github.com>
…tack-resources/_index.md

Co-authored-by: Matteo Rinaudo <52245107+mrinaudo-aws@users.noreply.github.com>
…tack-resources/_index.md

Co-authored-by: Matteo Rinaudo <52245107+mrinaudo-aws@users.noreply.github.com>
…tack-resources/_index.md

Co-authored-by: Matteo Rinaudo <52245107+mrinaudo-aws@users.noreply.github.com>
…tack-resources/_index.md

Co-authored-by: Matteo Rinaudo <52245107+mrinaudo-aws@users.noreply.github.com>
kumarev and others added 7 commits March 1, 2022 15:00
…tack-resources/_index.md

Co-authored-by: Matteo Rinaudo <52245107+mrinaudo-aws@users.noreply.github.com>
…tack-resources/_index.md

Co-authored-by: Matteo Rinaudo <52245107+mrinaudo-aws@users.noreply.github.com>
…tack-resources/_index.md

Co-authored-by: Matteo Rinaudo <52245107+mrinaudo-aws@users.noreply.github.com>
…tack-resources/_index.md

Co-authored-by: Matteo Rinaudo <52245107+mrinaudo-aws@users.noreply.github.com>
…tack-resources/_index.md

Co-authored-by: Matteo Rinaudo <52245107+mrinaudo-aws@users.noreply.github.com>
…tack-resources/_index.md

Co-authored-by: Matteo Rinaudo <52245107+mrinaudo-aws@users.noreply.github.com>
updated the link for EC2 console on line 161.
@mrinaudo-aws mrinaudo-aws self-requested a review March 1, 2022 20:37
mrinaudo-aws
mrinaudo-aws previously approved these changes Mar 1, 2022
Copy link
Contributor

@mrinaudo-aws mrinaudo-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@rezabekf rezabekf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small rewording of introduction. Other than that LGMT. Once my comment gets resolved, I am ready to merge.

rezabekf and others added 2 commits March 3, 2022 10:12
…tack-resources/_index.md

Co-authored-by: Franco Rezabek <43790446+rezabekf@users.noreply.github.com>
@kumarev
Copy link
Contributor Author

kumarev commented Mar 3, 2022

Just a small rewording of introduction. Other than that LGMT. Once my comment gets resolved, I am ready to merge.

Done, applied the suggestions. Thanks!

@kumarev kumarev closed this Mar 3, 2022
@kumarev kumarev reopened this Mar 3, 2022
replaced evolves with evolve
Copy link
Contributor

@rezabekf rezabekf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@rezabekf rezabekf merged commit a713361 into main Mar 3, 2022
@rezabekf rezabekf deleted the kumarev/update-behaviors-of-stack-resources branch March 3, 2022 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants