Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dreddy-aws/resource-return-values #159

Merged
merged 9 commits into from
Mar 10, 2022
Merged

Conversation

dreddy-aws
Copy link
Contributor

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@dreddy-aws dreddy-aws changed the title modified index.md file dreddy-aws/resource-return-values Mar 3, 2022
Copy link
Contributor

@mrinaudo-aws mrinaudo-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dreddy-aws thanks! Please review/approve/update, and request another review!

dreddy-aws and others added 2 commits March 9, 2022 11:48
Reviewed the suggested changes

Co-authored-by: Matteo Rinaudo <52245107+mrinaudo-aws@users.noreply.github.com>
@mrinaudo-aws mrinaudo-aws self-requested a review March 9, 2022 18:09
Copy link
Contributor

@mrinaudo-aws mrinaudo-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@mrinaudo-aws mrinaudo-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additional comment - please review/fix.

mrinaudo-aws
mrinaudo-aws previously approved these changes Mar 9, 2022
Copy link
Contributor

@mrinaudo-aws mrinaudo-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@rezabekf rezabekf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@rezabekf rezabekf merged commit 0585688 into main Mar 10, 2022
@rezabekf rezabekf deleted the dreddy-aws/resource-return-values branch March 10, 2022 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants