-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dreddy-aws/resource-return-values #159
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dreddy-aws thanks! Please review/approve/update, and request another review!
workshop/content/basics/templates/finding-output-values/_index.md
Outdated
Show resolved
Hide resolved
workshop/content/basics/templates/finding-output-values/_index.md
Outdated
Show resolved
Hide resolved
workshop/content/basics/templates/finding-output-values/_index.md
Outdated
Show resolved
Hide resolved
workshop/content/basics/templates/finding-output-values/_index.md
Outdated
Show resolved
Hide resolved
workshop/content/basics/templates/finding-output-values/_index.md
Outdated
Show resolved
Hide resolved
code/solutions/resource-return-values/resource-return-values-challenge.yaml
Outdated
Show resolved
Hide resolved
code/solutions/resource-return-values/resource-return-values-challenge.yaml
Outdated
Show resolved
Hide resolved
code/workspace/resource-return-values/resource-return-values-challenge.yaml
Outdated
Show resolved
Hide resolved
code/workspace/resource-return-values/resource-return-values-challenge.yaml
Outdated
Show resolved
Hide resolved
workshop/content/basics/templates/finding-output-values/_index.md
Outdated
Show resolved
Hide resolved
Reviewed the suggested changes Co-authored-by: Matteo Rinaudo <52245107+mrinaudo-aws@users.noreply.github.com>
…field in challenge template
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additional comment - please review/fix.
workshop/content/basics/templates/finding-return-values/_index.md
Outdated
Show resolved
Hide resolved
… image format in index file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Content cleanup
…s' into dreddy-aws/resource-return-values
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.