Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Architecting templates #167

Merged
merged 9 commits into from
Sep 20, 2022
Merged

Architecting templates #167

merged 9 commits into from
Sep 20, 2022

Conversation

mrinaudo-aws
Copy link
Contributor

Issue #, if available:

Description of changes:
Added architecting templates lab.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Contributor

@rezabekf rezabekf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few nit picks in parameter descriptions and some re-wording suggestions. Other than that all good from me. Nice Lab Matteo 👍

mrinaudo-aws and others added 7 commits September 20, 2022 08:48
Co-authored-by: Franco Rezabek <43790446+rezabekf@users.noreply.github.com>
…emplate

Co-authored-by: Franco Rezabek <43790446+rezabekf@users.noreply.github.com>
Co-authored-by: Franco Rezabek <43790446+rezabekf@users.noreply.github.com>
Co-authored-by: Franco Rezabek <43790446+rezabekf@users.noreply.github.com>
@mrinaudo-aws
Copy link
Contributor Author

Just a few nit picks in parameter descriptions and some re-wording suggestions. Other than that all good from me. Nice Lab Matteo 👍

Thank you, @rezabekf - I performed updates and also added a change to instruct the user to use a virtual environment for Python.

Copy link
Contributor

@rezabekf rezabekf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT

@rezabekf rezabekf merged commit 003a9ec into main Sep 20, 2022
@rezabekf rezabekf deleted the architecting-templates branch September 20, 2022 17:25
@rezabekf rezabekf restored the architecting-templates branch September 20, 2022 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants