Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translated workshop Prerequisites section in Japanese #175

Merged
merged 4 commits into from
Oct 18, 2022
Merged

Translated workshop Prerequisites section in Japanese #175

merged 4 commits into from
Oct 18, 2022

Conversation

cmick-aws
Copy link
Contributor

@tkimurz Please review Japanese translation.

@cmick-aws cmick-aws self-assigned this Oct 14, 2022
@cmick-aws cmick-aws requested a review from a team as a code owner October 14, 2022 10:23
uchiroki
uchiroki reviewed Oct 14, 2022
View reviewed changes
Copy link

@uchiroki uchiroki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

翻訳ありがとうございます！ 概ね問題ございません。細かい部分の修正をお願いします。

content/prerequisites/account/index.ja.md Outdated Show resolved Hide resolved
content/prerequisites/awscli/index.ja.md Outdated Show resolved Hide resolved
content/prerequisites/editor/index.ja.md Outdated Show resolved Hide resolved
@cmick-aws cmick-aws removed the request for review from tkimurz October 14, 2022 11:33
uchiroki
uchiroki previously approved these changes Oct 14, 2022
View reviewed changes
Copy link

@uchiroki uchiroki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also checked the fixed version . Finished reviewing.

@cmick-aws
Copy link
Contributor Author

cmick-aws commented Oct 17, 2022 •
edited
Loading

@rezabekf This PR has been reviewed in Japan side. Please squash merge.

@cmick-aws
Copy link
Contributor Author

@uchiroki , I also localized URLs for this part of the workshop, as decided. Please review.

uchiroki
uchiroki approved these changes Oct 18, 2022
View reviewed changes
Copy link

@uchiroki uchiroki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed the latest version. There is no problem at all.

rezabekf
rezabekf approved these changes Oct 18, 2022
View reviewed changes
Copy link
Contributor

@rezabekf rezabekf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT 👍

@rezabekf rezabekf merged commit e13d911 into main.ja Oct 18, 2022
@rezabekf rezabekf deleted the ja-03-prerequisites branch October 18, 2022 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rezabekf rezabekf rezabekf approved these changes

@uchiroki uchiroki uchiroki approved these changes

Assignees

@cmick-aws cmick-aws

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cmick-aws @rezabekf @uchiroki