Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dynamic-references updated for Cloud9 #211

Merged
merged 13 commits into from
May 17, 2023
Merged

dynamic-references updated for Cloud9 #211

merged 13 commits into from
May 17, 2023

Conversation

cjhar
Copy link
Contributor

@cjhar cjhar commented Apr 20, 2023

What does this PR do and why?

Updated instructions to use Cloud9 dev environment

Issue #, if available

PR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

  • Added/Updated documentation if applicable.
  • Pre-commit checks passed.
  • Lint and Nag checks passed.
  • If releasing a new version, have you bumped the version make version part=<major|minor|patch>?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@cjhar cjhar requested a review from a team as a code owner April 20, 2023 09:30
@cjhar
Copy link
Contributor Author

cjhar commented Apr 30, 2023

Updated to use CLI for Cloud9, ready for review please

@cjhar
Copy link
Contributor Author

cjhar commented May 10, 2023

Timing was ~30 minutes waiting for RDS cfn creation. This lesson doesn't have an estimated timings though.

Tested end2end

@sdangol
Copy link
Contributor

sdangol commented May 15, 2023

I was getting an error Cannot find version 8.0.26 for mysql when trying to deploy thecfn-workshop-dynamic-references-database stack. Can you please check

Copy link
Contributor

@sdangol sdangol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some feedbacks

@cjhar cjhar requested a review from sdangol May 16, 2023 12:11
sdangol
sdangol previously approved these changes May 17, 2023
Copy link
Contributor

@sdangol sdangol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rezabekf
Copy link
Contributor

rezabekf commented May 17, 2023

#211 (comment)

Perfect, I have added lab duration.

Copy link
Contributor

@rezabekf rezabekf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was the big one. Thanks all for contributing! LGMT

@rezabekf rezabekf merged commit 5a2bdc0 into main May 17, 2023
1 check passed
@rezabekf rezabekf deleted the dynamic-references branch May 17, 2023 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants