-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dynamic-references updated for Cloud9 #211
Conversation
Updated to use CLI for Cloud9, ready for review please |
Timing was ~30 minutes waiting for RDS cfn creation. This lesson doesn't have an estimated timings though. Tested end2end |
I was getting an error |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some feedbacks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Perfect, I have added lab duration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was the big one. Thanks all for contributing! LGMT
What does this PR do and why?
Updated instructions to use Cloud9 dev environment
Issue #, if available
PR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
make version part=<major|minor|patch>
?By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.