Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource-dependencies #222

Merged
merged 10 commits into from
May 15, 2023
Merged

resource-dependencies #222

merged 10 commits into from
May 15, 2023

Conversation

snjkumar23
Copy link
Contributor

@snjkumar23 snjkumar23 commented May 2, 2023

What does this PR do and why?

Changes for Cloud9 Integration

Issue #, if available

PR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

  • Added/Updated documentation if applicable.
  • Pre-commit checks passed.
  • Lint and Nag checks passed.
  • If releasing a new version, have you bumped the version make version part=<major|minor|patch>?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@snjkumar23 snjkumar23 requested a review from a team as a code owner May 2, 2023 16:08
@snjkumar23 snjkumar23 changed the title Changes for cloud9 integration resource-dependencies May 5, 2023
Copy link
Contributor

@cjhar cjhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Sanjeev, some errors to fix and suggested image updates

@snjkumar23 snjkumar23 requested a review from cjhar May 15, 2023 05:48
Copy link
Contributor

@cjhar cjhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, one small suggested change to make the line break/parameters clearer

Copy link
Contributor

@cjhar cjhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rezabekf rezabekf merged commit 57ff0e0 into main May 15, 2023
1 check passed
@rezabekf rezabekf deleted the resource-dependencies branch May 15, 2023 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants