Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cloud9 Support for Resource-Importing Lab #223

Merged
merged 16 commits into from
May 19, 2023
Merged

Cloud9 Support for Resource-Importing Lab #223

merged 16 commits into from
May 19, 2023

Conversation

AvinashSeelam9
Copy link
Contributor

What does this PR do and why?

This PR is for providing Cloud9 Support for Resource importing Lab

Describe in detail what your merge request does and why.
This PR is for providing Cloud9 Support for Resource importing Lab

Issue #, if available

PR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

  • Added/Updated documentation if applicable.
  • Pre-commit checks passed.
  • Lint and Nag checks passed.
  • If releasing a new version, have you bumped the version make version part=<major|minor|patch>?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@AvinashSeelam9 AvinashSeelam9 requested a review from a team as a code owner May 3, 2023 10:29
@AvinashSeelam9 AvinashSeelam9 requested a review from cjhar May 16, 2023 07:23
Copy link
Contributor

@cjhar cjhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of review changes for this one to make it consistent and provide more information to the user.

Also please remove the slashes from this x 2 near line 47 and line 142: arn\:aws\:sns\:us-east-1:123456789012\:MyTopic

cjhar

This comment was marked as duplicate.

@AvinashSeelam9 AvinashSeelam9 requested a review from cjhar May 17, 2023 10:02
Copy link
Contributor

@cjhar cjhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more comments, please update or resolve conversation as you prefer

AvinashSeelam9 and others added 7 commits May 17, 2023 16:15
Co-authored-by: Chris Harding <112917432+cjhar@users.noreply.github.com>
Co-authored-by: Chris Harding <112917432+cjhar@users.noreply.github.com>
Co-authored-by: Chris Harding <112917432+cjhar@users.noreply.github.com>
Co-authored-by: Chris Harding <112917432+cjhar@users.noreply.github.com>
Co-authored-by: Chris Harding <112917432+cjhar@users.noreply.github.com>
@AvinashSeelam9 AvinashSeelam9 requested a review from cjhar May 17, 2023 10:54
Copy link
Contributor

@cjhar cjhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found a few small issues

@AvinashSeelam9 AvinashSeelam9 requested a review from cjhar May 17, 2023 11:14
cjhar
cjhar previously approved these changes May 17, 2023
Copy link
Contributor

@cjhar cjhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@rezabekf rezabekf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was by far the hardest to do. Well done all!

@rezabekf rezabekf merged commit e6f421c into main May 19, 2023
1 check passed
@rezabekf rezabekf deleted the resource-importing branch May 19, 2023 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants