-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cloud9 Support for Resource-Importing Lab #223
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lots of review changes for this one to make it consistent and provide more information to the user.
Also please remove the slashes from this x 2 near line 47 and line 142: arn\:aws\:sns\:us-east-1:123456789012\:MyTopic
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few more comments, please update or resolve conversation as you prefer
Co-authored-by: Chris Harding <112917432+cjhar@users.noreply.github.com>
Co-authored-by: Chris Harding <112917432+cjhar@users.noreply.github.com>
Co-authored-by: Chris Harding <112917432+cjhar@users.noreply.github.com>
Co-authored-by: Chris Harding <112917432+cjhar@users.noreply.github.com>
Co-authored-by: Chris Harding <112917432+cjhar@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found a few small issues
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was by far the hardest to do. Well done all!
What does this PR do and why?
This PR is for providing Cloud9 Support for Resource importing Lab
Describe in detail what your merge request does and why.
This PR is for providing Cloud9 Support for Resource importing Lab
Issue #, if available
PR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
make version part=<major|minor|patch>
?By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.