Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missed c9 issues #226

Merged
merged 17 commits into from
May 11, 2023
Merged

Fix missed c9 issues #226

merged 17 commits into from
May 11, 2023

Conversation

rezabekf
Copy link
Contributor

@rezabekf rezabekf commented May 5, 2023

What does this PR do and why?

Some minor changes, mainly consistent naming and disabling copy on STDOUT.

Issue #, if available

PR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

  • Added/Updated documentation if applicable.
  • Pre-commit checks passed.
  • Lint and Nag checks passed.
  • If releasing a new version, have you bumped the version make version part=<major|minor|patch>?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@rezabekf rezabekf requested a review from a team as a code owner May 5, 2023 13:41
@rezabekf rezabekf requested a review from sdangol May 9, 2023 14:22
@rezabekf rezabekf requested a review from sdangol May 9, 2023 16:55
@rezabekf rezabekf self-assigned this May 9, 2023
Copy link
Contributor Author

@rezabekf rezabekf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR feedback pushed

content/basics/templates/mappings/index.md Show resolved Hide resolved
content/basics/templates/mappings/index.md Show resolved Hide resolved
@rezabekf rezabekf requested a review from sdangol May 10, 2023 15:47
Copy link
Contributor

@sdangol sdangol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found some more

Co-authored-by: Swopnil Dangol <swopnildangol@gmail.com>
@rezabekf rezabekf requested a review from sdangol May 11, 2023 10:43
Copy link
Contributor

@sdangol sdangol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rezabekf rezabekf merged commit ad4f158 into main May 11, 2023
1 check passed
@rezabekf rezabekf deleted the fix-missed-c9-issues branch May 11, 2023 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants