Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update aws cli to v2 #230

Merged
merged 6 commits into from
May 15, 2023
Merged

Update aws cli to v2 #230

merged 6 commits into from
May 15, 2023

Conversation

rezabekf
Copy link
Contributor

What does this PR do and why?

Add instructions and script to migrate AWS CLI v1 to AWS CLI v2.

Issue #, if available

PR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

  • Added/Updated documentation if applicable.
  • Pre-commit checks passed.
  • Lint and Nag checks passed.
  • If releasing a new version, have you bumped the version make version part=<major|minor|patch>?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@rezabekf rezabekf requested a review from a team as a code owner May 12, 2023 11:29
@rezabekf rezabekf requested a review from sdangol May 12, 2023 11:31
@rezabekf rezabekf self-assigned this May 12, 2023
@rezabekf
Copy link
Contributor Author

FYI, the script only assumes that awscli v1 is installed via yum which is the case at the moment. I thought it would be overkill to check for all the possible ways to install awscli...it can be pip, brew and what not...possibly we could add the official docs links at the end for people to install manually if our way fails?

Copy link
Contributor

@cjhar cjhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Franco, other than the order this tested okay on a fresh Cloud9 instance in us-east-1

content/prerequisites/cloud9/index.md Outdated Show resolved Hide resolved
Copy link
Contributor

@sdangol sdangol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rezabekf rezabekf merged commit aa4b5d7 into main May 15, 2023
1 check passed
@rezabekf rezabekf deleted the c9-awscliv2 branch May 15, 2023 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants