Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Language extensions #232

Merged
merged 6 commits into from
May 26, 2023
Merged

Language extensions #232

merged 6 commits into from
May 26, 2023

Conversation

AvinashSeelam9
Copy link
Contributor

What does this PR do and why?

This PR provides Cloud9 Support for Language Extensions Lab
Describe in detail what your merge request does and why.
This PR provides Cloud9 Support for Language Extensions Lab

Issue #, if available

PR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

  • Added/Updated documentation if applicable.
  • Pre-commit checks passed.
  • Lint and Nag checks passed.
  • If releasing a new version, have you bumped the version make version part=<major|minor|patch>?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@AvinashSeelam9 AvinashSeelam9 requested a review from a team as a code owner May 22, 2023 15:07
@AvinashSeelam9 AvinashSeelam9 requested a review from cjhar May 22, 2023 15:08
Copy link
Contributor

@cjhar cjhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, just some small corrections to the clean up section. Also we could ask the user to inspect the dashboard source to verify the template created properly

@AvinashSeelam9 AvinashSeelam9 requested a review from cjhar May 24, 2023 07:13
Copy link
Contributor

@cjhar cjhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@rezabekf rezabekf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one! LGMT

@rezabekf rezabekf merged commit d247c32 into main May 26, 2023
1 check passed
@rezabekf rezabekf deleted the language-extensions branch May 26, 2023 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants