Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tag to description #235

Merged
merged 2 commits into from
Jul 26, 2023
Merged

Add tag to description #235

merged 2 commits into from
Jul 26, 2023

Conversation

rezabekf
Copy link
Contributor

What does this PR do and why?

This PR adds tag to CloudFormation templates.

Issue #, if available

PR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

  • Added/Updated documentation if applicable.
  • Pre-commit checks passed.
  • Lint and Nag checks passed.
  • If releasing a new version, have you bumped the version make version part=<major|minor|patch>?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@rezabekf rezabekf requested a review from a team as a code owner July 24, 2023 16:52
@rezabekf rezabekf self-assigned this Jul 24, 2023
Copy link
Contributor

@ConnorKirk ConnorKirk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. I spotted one inconsistency that I suggest we change.

@rezabekf rezabekf requested a review from ConnorKirk July 25, 2023 09:02
@rezabekf rezabekf merged commit 07b895a into main Jul 26, 2023
1 check passed
@rezabekf rezabekf deleted the rezabekf/add-tag branch January 9, 2024 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants