Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken links #257

Merged
merged 1 commit into from
Dec 5, 2023
Merged

Fix broken links #257

merged 1 commit into from
Dec 5, 2023

Conversation

jlosito
Copy link
Contributor

@jlosito jlosito commented Dec 4, 2023

What does this PR do and why?

This fixes some broken links in the Linting and testing page.

Issue #, if available

#256

PR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

  • Added/Updated documentation if applicable.
  • Pre-commit checks passed.
  • Lint and Nag checks passed.
  • If releasing a new version, have you bumped the version make version part=<major|minor|patch>?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@jlosito jlosito marked this pull request as ready for review December 4, 2023 18:41
@jlosito jlosito requested a review from a team as a code owner December 4, 2023 18:41
@cmick-aws
Copy link
Contributor

@jlosito I created a new PR #259 including a more complete URL fixes, and also fixes for Japanese language.
Please check.

Copy link
Contributor

@rezabekf rezabekf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT 👍

@rezabekf rezabekf merged commit 51f77e0 into aws-samples:main Dec 5, 2023
2 checks passed
@jlosito jlosito deleted the broken-links branch December 5, 2023 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants