Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the images paths in the 100-account.md #98

Closed

Conversation

pablogarciaarevalo
Copy link

Fix the images path with the same folder instead of the parent folder

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Fix the images path with the same folder instead of the parent folder
@pablogarciaarevalo pablogarciaarevalo changed the title Fix the images path Fix the images paths in the 100-account.md Dec 28, 2020
@rezabekf
Copy link
Contributor

Thank you for the patch, I will review this tomorrow and merge once the tests pass.
Cheers Franco

@rezabekf rezabekf self-requested a review December 28, 2020 19:06
@rezabekf rezabekf added the documentation Improvements or additions to documentation label Dec 28, 2020
@rezabekf rezabekf closed this Dec 29, 2020
Copy link
Contributor

@rezabekf rezabekf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, the markdown used for this workshop is using Hugo short-codes. Unfortunately, Hugo short-codes aren't supported in GitHub and I would suggest to use official workshop website, which renders links and images correctly. More info on official Hugo support page

At this point, I can not merge this PR into the master as it would break the web site.

Thanks,
Franco

@pablogarciaarevalo
Copy link
Author

pablogarciaarevalo commented Dec 29, 2020

Hello Franco.

It seems that it works in the .sa.engineering domain but not in the workshop.aws. An example:

Regards,
Pablo

@rezabekf
Copy link
Contributor

Great find, I wasn't aware, that the workshop has been already moved to official AWS workshop site. I will contact the owner of the domain. This is most likely issue with outdated Hugo framework within the AWS Amplify service. I will reopen this as an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants