Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Time frame corrected to refresh token soon to expire. #54

Merged
merged 2 commits into from
May 12, 2020
Merged

Time frame corrected to refresh token soon to expire. #54

merged 2 commits into from
May 12, 2020

Conversation

BartoGabriel
Copy link
Contributor

#52: 60 * 5 (5 minutes) should be added not subtracted in the early token refresh logic.

@ottokruse
Copy link
Collaborator

ottokruse commented May 11, 2020 •
edited

Thanks for the PR!
Looks good.
One thing though, I think tsconfig.tsbuildinfo should be added to .gitignore?

@BartoGabriel
Copy link
Contributor Author

Yes, I am going to add it to the .gitignore and remove it if you agree.

@ottokruse ottokruse merged commit 527e408 into aws-samples:master May 12, 2020
@ottokruse
Copy link
Collaborator

THANK YOU! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@BartoGabriel @ottokruse