Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Remove usage of eksctl #32

Closed
bryantbiggs opened this issue Feb 13, 2023 · 2 comments
Closed

Feature: Remove usage of eksctl #32

bryantbiggs opened this issue Feb 13, 2023 · 2 comments

Comments

@bryantbiggs
Copy link
Member

Summary

eksctl already provides support for upgrading the control plane of a cluster created by its CLI https://eksctl.io/usage/cluster-upgrade/

This is mainly done just to keep the generated CloudFormation in-sync with any changes. It currently does not support upgrading any components of the data plane; these are handled in the same way that upgrades are handled here. Therefore, the data plane and addon upgrade logic and be used on clusters created by eksctl and a separate, unique process does not need to exists

Why is this needed?

If users are using eksctl today, they should continue using it to perform upgrades of the control plane as per eksctl. Since eksctl does not support upgrading any components of the data plane, we can still support that process with eksupgrade

Which area does this relate to?

Automation

Solution

  • We can keep this wrapped call to eksctl or we can replace it and instruct users to upgrade the control plane first.

  • Functionality will need to be added to support performing data plane only upgrades. This process will inspect the control plane version and update the data plane components to match (update nodegroups, Fargate profiles, addon default versions, etc.). This is useful both for the eksctl scenario as well as for the guidance provided to users to ensure the data plane components are aligned with the control plane prior to upgrading. Therefore, users can also use this functionality to align their data plane with the control plane prior to performing an upgrade

@bryantbiggs bryantbiggs changed the title Maintenance: Remove usage of eksctl Feature: Remove usage of eksctl Feb 13, 2023
@bryantbiggs
Copy link
Member Author

I guess this is more of a feature rather than maintenance (in hindsight)

@mbeacom
Copy link
Contributor

mbeacom commented Feb 14, 2023

The eksctl functionality is totally inaccessible to the enduser right now:

if args.eksctl:
sys.exit("updating using EKSCTL is still under testing will be launched soon")

We may as well remove it and if desired, re-add something in the new interface.

mbeacom added a commit to mbeacom/eks-cluster-upgrade that referenced this issue Feb 14, 2023
@mbeacom mbeacom closed this as completed Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants