Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: Manual patching of addon removal #61

Closed
mbeacom opened this issue Feb 22, 2023 · 0 comments · Fixed by #62
Closed

Bug: Manual patching of addon removal #61

mbeacom opened this issue Feb 22, 2023 · 0 comments · Fixed by #62
Assignees
@mbeacom
Labels
bug Something isn't working

Comments

@mbeacom
Copy link
Contributor

mbeacom commented Feb 22, 2023

Expected Behaviour

Executing eksupgrade against a cluster should engage with the EKS API to upgrade supported addons versus attempting to patch with some arbitrary manifest derived from this codebase.

Current Behaviour

  • Attempts to patch the deployment or daemonset directly
  • Subsequently calls the EKS API to upgrade the addon

Code snippet

N/A

Possible Solution

Remove the manual patching of deployments/daemonsets for supported addons (coredns, vpc-cni, kube-proxy)

Steps to Reproduce

Execute eksupgrade against a cluster.

Amazon EKS upgrade version

latest

Python runtime version

3.8

Packaging format used

PyPi

Debugging logs

No response
@mbeacom mbeacom added the bug Something isn't working label Feb 22, 2023
@mbeacom mbeacom self-assigned this Feb 22, 2023
mbeacom added a commit to mbeacom/eks-cluster-upgrade that referenced this issue Feb 22, 2023
@mbeacom
Resolve aws-samples#61 - Remove patching of addon resources and assoc…
df18253 
…iated static files
@mbeacom mbeacom mentioned this issue Feb 22, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mbeacom mbeacom

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Remove patching of addon resources and associated static assets mbeacom/eks-cluster-upgrade
1 participant
@mbeacom