Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep Host header intact #4

Merged
merged 6 commits into from
Aug 21, 2023
Merged

Keep Host header intact #4

merged 6 commits into from
Aug 21, 2023

Conversation

kichik
Copy link
Contributor

@kichik kichik commented Jan 18, 2022

Set the Host header to match that of the original request. This allows to more easily handle the mirrored traffic, especially if the source handles multiple virtual hosts.


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@SimonePomata
Copy link
Contributor

The original Host header is added to the X-Forwarded-Host header. The current behaviour is expected by some applications.
Anyway, I also see the use case for keeping the orignial Host header.

My proposal is to add a KeepOriginalHostHeader parameter to the CloudFormation template, which is false by default (for backwards compatibility), but can also be set to true.
@kichik any thoughts?

@kichik
Copy link
Contributor Author

kichik commented Feb 6, 2022

Yeah makes total sense. I went ahead and added the parameter as requested.

@SimonePomata
Copy link
Contributor

thanks @kichik! I will review and merge in the coming days.

@SimonePomata SimonePomata merged commit 2880433 into aws-samples:main Aug 21, 2023
@kichik kichik deleted the patch-1 branch August 21, 2023 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants