Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CognitoID / aws_user_pools_id config on client unused? #35

Closed
jamesrowen opened this issue Jul 16, 2020 · 4 comments · Fixed by #36
Closed

CognitoID / aws_user_pools_id config on client unused? #35

jamesrowen opened this issue Jul 16, 2020 · 4 comments · Fixed by #36
Assignees
@mikeapted
Labels
question

Comments

@jamesrowen
Copy link

jamesrowen commented Jul 16, 2020 •
edited

The CognitoID output by the template is used to populate the aws_user_pools_id config on the client. This isn't referenced anywhere, and it seems to be redundant with the Cognito API token. Is there any use for this config?

lambda-refarch-webapp/template.yaml

Lines 369 to 371 in a9ced65

CognitoID:
Description: The Cognito UserPool ID
Value: !Ref TodoUserPool

and

lambda-refarch-webapp/www/src/config.js

Line 6 in a9ced65

"aws_user_pools_id": "None", // CognitoID

@jamesrowen
Copy link
Author

Looks like aws_cognito_region is also unused.

lambda-refarch-webapp/www/src/config.js

Line 5 in a9ced65

"aws_cognito_region": "us-east-1",

@dgomesbr
Copy link
Contributor

@mikeapted ?

@dgomesbr dgomesbr assigned dgomesbr and mikeapted and unassigned dgomesbr Jul 17, 2020
@mikeapted
Copy link
Contributor

Good observation. Neither of those config values are used by the front end application at this point. If we weren't using the hosted UI for login we might use those values but they can be removed here. Will update.

@jamesrowen
Copy link
Author

Sounds good, thanks!

mikeapted added a commit to mikeapted/lambda-refarch-webapp that referenced this issue Jul 19, 2020
@mikeapted
Udpates to deployment script and config files. Closes aws-samples#35
3c25d0d
@mikeapted mikeapted mentioned this issue Jul 19, 2020
Merged
mikeapted added a commit that referenced this issue Jul 19, 2020
@mikeapted
Merge pull request #36 from mikeapted/master
77937da 
Updates to deployment script and config files. Closes #35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mikeapted mikeapted

Labels
question
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Updates to deployment script and config files. Closes #35 mikeapted/lambda-refarch-webapp
3 participants
@dgomesbr @jamesrowen @mikeapted