Skip to content
This repository has been archived by the owner on Jun 26, 2024. It is now read-only.

CognitoID / aws_user_pools_id config on client unused? #35

Closed
jamesrowen opened this issue Jul 16, 2020 · 4 comments · Fixed by #36
Closed

CognitoID / aws_user_pools_id config on client unused? #35

jamesrowen opened this issue Jul 16, 2020 · 4 comments · Fixed by #36
Assignees
Labels

Comments

@jamesrowen
Copy link

jamesrowen commented Jul 16, 2020

The CognitoID output by the template is used to populate the aws_user_pools_id config on the client. This isn't referenced anywhere, and it seems to be redundant with the Cognito API token. Is there any use for this config?

CognitoID:
Description: The Cognito UserPool ID
Value: !Ref TodoUserPool

and

"aws_user_pools_id": "None", // CognitoID

@jamesrowen
Copy link
Author

Looks like aws_cognito_region is also unused.

"aws_cognito_region": "us-east-1",

@dgomesbr
Copy link
Contributor

@mikeapted ?

@dgomesbr dgomesbr assigned dgomesbr and mikeapted and unassigned dgomesbr Jul 17, 2020
@mikeapted
Copy link
Contributor

Good observation. Neither of those config values are used by the front end application at this point. If we weren't using the hosted UI for login we might use those values but they can be removed here. Will update.

@jamesrowen
Copy link
Author

Sounds good, thanks!

mikeapted added a commit to mikeapted/lambda-refarch-webapp that referenced this issue Jul 19, 2020
mikeapted added a commit that referenced this issue Jul 19, 2020
Updates to deployment script and config files. Closes #35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants