Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/karpenter #7

Merged
merged 7 commits into from
Jul 14, 2022
Merged

Feature/karpenter #7

merged 7 commits into from
Jul 14, 2022

Conversation

SpringMT
Copy link
Contributor

Issue #, if available:
N/A
Description of changes:
Use Karpenter instead of Cluster Autoscaler

@tmokmss
Copy link
Contributor

tmokmss commented Jul 14, 2022

@SpringMT Could you also remove modules/cluster_autoscaler directory? It should not be referenced from anywhere.

@SpringMT
Copy link
Contributor Author

It would be better to delete modules/cluster_autoscaler directory.
I'll delete it.

tmokmss
tmokmss reviewed Jul 14, 2022
View reviewed changes
modules/karpenter/main.tf Outdated Show resolved Hide resolved
@SpringMT
Copy link
Contributor Author

@tmokmss I fixed all comments.

@tmokmss
Copy link
Contributor

tmokmss commented Jul 14, 2022

LGTM, Thanks! I'll also add a mention about Karpenter on README.md later.
BTW the previous cluster autoscaler version is always accessible via cluster_autoscaler tag 👍

@tmokmss tmokmss merged commit 4e32500 into aws-samples:main Jul 14, 2022
@SpringMT SpringMT deleted the feature/karpenter branch July 14, 2022 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmokmss tmokmss tmokmss left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SpringMT @tmokmss