Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Region check for Personalize content generator #568

Merged
merged 2 commits into from
Apr 9, 2024

Conversation

james-jory
Copy link
Contributor

Description of changes:

  • Since the Personalize content generator feature is only available in a subset of regions where Personalize is available, added a check to skip the automated content generator logic when enabled at deployment.

Description of testing performed to validate your changes (required if pull request includes CloudFormation or source code changes):

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@BastLeblanc
Copy link
Contributor

Looks good.
Shall we amend the supported regions in the README with "fully supported" and some other where we can deploy but no GED or no Bedrock?

@james-jory
Copy link
Contributor Author

Shall we amend the supported regions in the README with "fully supported" and some other where we can deploy but no GED or no Bedrock?

Sure. Made some updates to the supported regions table.

Copy link
Contributor

@BastLeblanc BastLeblanc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BastLeblanc BastLeblanc merged commit 287b27f into aws-samples:master Apr 9, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Shipped
Development

Successfully merging this pull request may close these issues.

None yet

2 participants