Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gitignore RVM config of those who are contributing #4

Merged
merged 1 commit into from
Dec 11, 2018

Conversation

equivalent
Copy link
Contributor

@equivalent equivalent commented Dec 5, 2018

Description of changes:

Given I'm a new contributor who wants to clone aws-samples/serverless-sinatra-sample
And I use RVM or RBENV
Then I would have to create .ruby-version .ruby-gemset in order to bundle install

Given I want to contribute new PR
Then I don't want to accidentally commit my .ruby-version & .ruby-gemset

...or alternatively we can keep the .ruby-version & .ruby-gemset commited in the project by default dictating what ruby version in the project requiring . In that case pls Close this PR

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@xiangshen-dk xiangshen-dk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@xiangshen-dk xiangshen-dk merged commit 2ea8341 into aws-samples:master Dec 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants