Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pin PyYAML to 5.3.1 in source setup.py #184

Closed
wants to merge 1 commit into from

Conversation

awseric
Copy link

@awseric awseric commented Jan 26, 2024

This fixes #183 by pinning PyYAML to version 5.3.1 in setup.py.
I understand contributions are not being accepted currently, so I will use my fork until this gets merged, but wanted to get the core team's attention to the bug and it's fix.

Contributing to Customizations for AWS Control Tower (CfCT).

Thank you for your interest in contributing to Customizations for AWS Control Tower (CfCT).

At this time, we are not accepting contributions. If contributions are accepted in the future, Customizations for AWS Control Tower (CfCT) is released under the Apache license and any code submitted will be released under that license.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@snebhu3
Copy link

snebhu3 commented Feb 6, 2024

@awseric thank you for bringing this up.
I will create a backlog to look into this.

@wiltangg
Copy link
Collaborator

wiltangg commented Jun 3, 2024

Hi @awseric , thank you again for bringing this to our attention. Latest patch v.2.7.1 (release notes) included changes to pin the PyYAML in setup.py to 5.3.1.

I am going to resolve this issue, please reopen if there are follow up questions.

@wiltangg wiltangg closed this Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

build-s3-dist.sh fails with pip error
3 participants