Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create Solutions GitHub workflow files. #383

Merged
merged 1 commit into from
Feb 28, 2023
Merged

Create Solutions GitHub workflow files. #383

merged 1 commit into from
Feb 28, 2023

Conversation

dch90
Copy link
Contributor

@dch90 dch90 commented Feb 16, 2023 •
edited
Loading

Description of changes:

  • Github Workflow file changes.
    • The new will allow contributors' code changes to run against AWS CodeBuild and Viperlight

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@dch90 dch90 self-assigned this Feb 16, 2023
@dch90 dch90 force-pushed the solutions-pipelines-integration branch 8 times, most recently from d0ea040 to 94f7ba2 Compare February 17, 2023 22:50
@dch90 dch90 temporarily deployed to push_env February 17, 2023 22:55 — with GitHub Actions Inactive
@dch90 dch90 force-pushed the solutions-pipelines-integration branch from 94f7ba2 to 1828315 Compare February 17, 2023 23:28
@dch90 dch90 temporarily deployed to push_env February 17, 2023 23:34 — with GitHub Actions Inactive
@dch90 dch90 changed the base branch from feature/v1.12.0 to development February 25, 2023 01:53
@aws-solutions-github-bot @dch90
Create Solutions GitHub workflow files and apply fixes for workflow
aaa6bf9 
Changes
=======

- add timeout in requests.post from msam/chalicelib/periodic.py:433 (pylint)
- include NOTICE.txt:209 in .viperlightignore (viperlight)
- Updated Github Actions to use latest version in order to utilize node v16 (older actions use node v12)
- temporary disable `pally-check-job` as issues are found in pa11y library
    - pa11y/pa11y#651
    - pa11y/pa11y#662
@dch90 dch90 force-pushed the solutions-pipelines-integration branch from 1828315 to aaa6bf9 Compare February 25, 2023 02:24
@dch90 dch90 requested a review from eggoynes February 25, 2023 02:25
@dch90 dch90 added the CI/CD finding Issues found with CI/CD workflows label Feb 25, 2023
@dch90 dch90 temporarily deployed to push_env February 25, 2023 02:29 — with GitHub Actions Inactive
@dch90 dch90 removed the CI/CD finding Issues found with CI/CD workflows label Feb 25, 2023
@dch90 dch90 mentioned this pull request Feb 28, 2023
Merged
eggoynes
eggoynes approved these changes Feb 28, 2023
View reviewed changes
Copy link
Member

@eggoynes eggoynes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@dch90 dch90 merged commit 64f2e86 into development Feb 28, 2023
@dch90 dch90 deleted the solutions-pipelines-integration branch March 28, 2023 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eggoynes eggoynes eggoynes approved these changes

Assignees

@dch90 dch90

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dch90 @eggoynes @aws-solutions-github-bot