Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

validate image resize dimensions #463

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

ericbuehl
Copy link

Issue #, if available: -

Description of changes:
Clients who request invalid image resize dimensions should get a 4xx error rather than a 5xx

Checklist

  • 馃憢 I have added unit tests for all code changes.
  • 馃憢 I have run the unit tests, and all unit tests have passed.
  • 鈿狅笍 This pull request might incur a breaking change.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@dougtoppin
Copy link
Member

@ericbuehl thank you for your submission, we will add it to our backlog for evaluation and get back to you. sorry about the delay in responding.

@ericbuehl
Copy link
Author

hello -- any updates here?

@ericbuehl
Copy link
Author

@dougtoppin any updates here? thank you!

@simonkrol
Copy link
Member

Hi @ericbuehl,

As an update here, we've decided to implement this change. It would be considered a breaking change, so we've marked it to be included in the next major release. While our internal policy has us make the changes manually, once the release is out, you'll see your profile and this PR referenced in the External Contributors section towards the bottom of the readme, and this PR will be closed.

Thanks for your contributions to the Serverless Image Handler :)
Simon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants