Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: AUTO_WEBP should work if accept header is lowercase #490

Closed
wants to merge 1 commit into from

Conversation

ccchapman
Copy link

@ccchapman ccchapman commented Jul 5, 2023

Issue #, if available: #467

Description of changes:

AUTO_WEBP should work if accept header is lowercase

Refs: aws/aws-sam-cli#3083 (comment)

Checklist

  • 馃憢 I have added unit tests for all code changes.
  • 馃憢 I have run the unit tests, and all unit tests have passed.
  • 鈿狅笍 This pull request might incur a breaking change.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@simonkrol simonkrol self-requested a review July 6, 2023 14:57
Copy link
Member

@simonkrol simonkrol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ccchapman,
Thanks for the contribution, I think that this looks good. I'll add it to the backlog and look to have it included.
Thanks,
Simon

@ccchapman ccchapman changed the title fix: AUTO_WEBP should work if accepts header is lowercase fix: AUTO_WEBP should work if accept header is lowercase Jul 6, 2023
@dougtoppin dougtoppin mentioned this pull request Dec 15, 2023
3 tasks
@dougtoppin
Copy link
Member

addressed with v6.2.4

@dougtoppin dougtoppin closed this Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants