Fix warnings with -Wall -Wextra enabled #41
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
When library is compiled with
-Wextra
on ARM GCC compiler (arm-none-eabi-gcc
) the following warnings are emitted:Description of changes:
This PR fixes that by removing the
( format < FleetProvisioningJson )
and( topic < FleetProvisioningPublish )
checks as they are always false.format
andtopic
are of the typeFleetProvisioningFormat_t
andFleetProvisioningApiTopics_t
, thus wont be less than the minimum valuesFleetProvisioningJson
andFleetProvisioningPublish
respectively.[ ] I have modified and/or added unit-tests to cover the code changes in this Pull Request.By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.