Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to set maxBitRateKbps for local video and content share #464

Merged
merged 2 commits into from
Aug 5, 2022

Conversation

ziyiz-amzn
Copy link
Contributor

@ziyiz-amzn ziyiz-amzn commented Jun 7, 2022

ℹ️ Description

Provide a way to configure video send encoding parameters when start local video and content share.

Issue #, if available

Chime-48548

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
    • README update
    • CHANGELOG update
    • guildes update
  • This change requires a dependency update
    • Amazon Chime SDK Media
    • Other (update corresonding legal documents)

🧪 How Has This Been Tested?

describe the tests that you ran to verify your changes, any relevant details for your test configuration
Start local video and content share with different maxBitRateKbps values, verified the metrics videoSendBitrate is closed to the maxBitRateKbps value.

Unit test coverage

  • Class coverage:
  • Line coverage:

Additional Manual Test

  • Pause and resume remote video
  • Switch local camera
  • Rotate screen back and forth

📱 Screenshots, if available

video_config1
video_config2
video_config3

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@ziyiz-amzn ziyiz-amzn requested review from hensmi-amazon and a team June 7, 2022 02:00
@codecov
Copy link

codecov bot commented Aug 5, 2022

Codecov Report

Merging #464 (c8de3cf) into development (3627522) will increase coverage by 0.06%.
The diff coverage is 66.66%.

Impacted file tree graph

@@                Coverage Diff                @@
##             development     #464      +/-   ##
=================================================
+ Coverage          59.31%   59.37%   +0.06%     
- Complexity            13       14       +1     
=================================================
  Files                135      136       +1     
  Lines               4188     4209      +21     
  Branches             567      570       +3     
=================================================
+ Hits                2484     2499      +15     
- Misses              1449     1451       +2     
- Partials             255      259       +4     
Impacted Files Coverage Δ
...ideo/contentshare/DefaultContentShareController.kt 77.77% <0.00%> (-22.23%) ⬇️
...sdk/meetings/audiovideo/DefaultAudioVideoFacade.kt 73.13% <66.66%> (+1.25%) ⬆️
...etings/audiovideo/video/LocalVideoConfiguration.kt 66.66% <66.66%> (ø)
...tshare/DefaultContentShareVideoClientController.kt 73.52% <66.66%> (-0.32%) ⬇️
...ngs/internal/video/DefaultVideoClientController.kt 38.84% <75.00%> (+2.20%) ⬆️
...meetings/audiovideo/DefaultAudioVideoController.kt 86.15% <100.00%> (+0.43%) ⬆️

@ziyiz-amzn ziyiz-amzn merged commit 5ae19d4 into development Aug 5, 2022
@ziyiz-amzn ziyiz-amzn deleted the video-config branch August 5, 2022 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants