-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support to set maxBitRateKbps for local video and content share #464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...n/java/com/amazonaws/services/chime/sdk/meetings/audiovideo/video/LocalVideoConfiguration.kt
Outdated
Show resolved
Hide resolved
linsang21
reviewed
Jun 7, 2022
...main/java/com/amazonaws/services/chime/sdk/meetings/audiovideo/AudioVideoControllerFacade.kt
Show resolved
Hide resolved
...n/java/com/amazonaws/services/chime/sdk/meetings/audiovideo/video/LocalVideoConfiguration.kt
Outdated
Show resolved
Hide resolved
...est/java/com/amazonaws/services/chime/sdk/meetings/audiovideo/DefaultAudioVideoFacadeTest.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/amazonaws/services/chime/sdkdemo/fragment/MeetingFragment.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/amazonaws/services/chime/sdkdemo/fragment/DeviceManagementFragment.kt
Outdated
Show resolved
Hide resolved
42975f0
to
161a610
Compare
Codecov Report
@@ Coverage Diff @@
## development #464 +/- ##
=================================================
+ Coverage 59.31% 59.37% +0.06%
- Complexity 13 14 +1
=================================================
Files 135 136 +1
Lines 4188 4209 +21
Branches 567 570 +3
=================================================
+ Hits 2484 2499 +15
- Misses 1449 1451 +2
- Partials 255 259 +4
|
hokyungh
reviewed
Aug 5, 2022
...n/java/com/amazonaws/services/chime/sdk/meetings/audiovideo/video/LocalVideoConfiguration.kt
Outdated
Show resolved
Hide resolved
...ervices/chime/sdk/meetings/internal/contentshare/DefaultContentShareVideoClientController.kt
Outdated
Show resolved
Hide resolved
...n/java/com/amazonaws/services/chime/sdk/meetings/audiovideo/video/LocalVideoConfiguration.kt
Outdated
Show resolved
Hide resolved
...ava/com/amazonaws/services/chime/sdk/meetings/internal/video/DefaultVideoClientController.kt
Show resolved
Hide resolved
...ervices/chime/sdk/meetings/internal/contentshare/DefaultContentShareVideoClientController.kt
Show resolved
Hide resolved
georgezy-amzn
approved these changes
Aug 5, 2022
hokyungh
approved these changes
Aug 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ℹ️ Description
Provide a way to configure video send encoding parameters when start local video and content share.
Issue #, if available
Chime-48548
Type of change
🧪 How Has This Been Tested?
describe the tests that you ran to verify your changes, any relevant details for your test configuration
Start local video and content share with different maxBitRateKbps values, verified the metrics videoSendBitrate is closed to the maxBitRateKbps value.
Unit test coverage
Additional Manual Test
📱 Screenshots, if available
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.