New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support React 18 + TypeScript #786
Comments
Thanks for reporting this issue. We will provide more updates as we make progress. But for now we are tracking this internally. |
@kelvin-thinkbean amazon-chime-sdk-component-library-react peer dependencies include react v17. Did you use --force or --legacy-peer-deps to get react v18 installed? |
@devalevenkatesh are there immediate plans for upgrading the peer dep? it is blocking us from upgrading. thanks for a great lib! |
Hi @beefancohen , Thank you for trying out the library. Unfortunately, I am sad to tell we have not yet prioritized due to other priorities. I will keep this issue updated once we have an update. Thanks again! |
@devalevenkatesh thank you! would you accept a PR perhaps? |
Yes, definitely would like that. Though, there are multiple problem with React 18 upgrade for us and time consuming to fix. Below are the things we need to update in order:
We did some progress and realized there're more than 70+ *.stories.tsx of UI Components need to be migrated from @storybook/addon-knob to @storybook/addon-controls. Example: ec95996 |
awesome ty... posting the migration instructions for storybook here for posterity: https://github.com/storybookjs/storybook/blob/next/code/addons/controls/README.md#how-do-i-migrate-from-addon-knobs |
The major issue for migrate to |
+1 |
Still having the same problem with the last update (3.4.0), is there any workaround for this? |
with react 17, I'm getting this issue with
|
Thanks for reporting @Robertorc83 and @osamabinsaleem . This is not a bug with the library rather React 18 is not supported yet with |
+1 Please. Is there any timeframe as of yet? |
1 similar comment
+1 Please. Is there any timeframe as of yet? |
I made a version where I got rid of story book altogether and did all the adding children prop to components work and it builds successfully, do you want me to commit a branch where items 2, 3 and 4 are done? |
I published this version which is working on react 18 https://www.npmjs.com/package/chime-sdk-react-unoffical-18 |
+1 have been facing some issue in chime front end integration, and I am trying to use any tag from Amazon chime SDK component library react getting error. Example tag : Chime version : "amazon-chime-sdk-component-library-react": "^3.4.0", "amazon-chime-sdk-js": "^3.9.0" dependencies version : |
We built all our front end app using react 18. Since chime is not supported in react 18, we need to do lot of work around like creating a separate react app to compile down it to simple js code and include them in main app inside iframe. It caused lot of churn and delayed the project deliverables. We think that it is going to cause continuous maintanence issues. I would request the team to prioritize this issue and upgrade the library. Thank you. |
I am actually working on the react 18 implementation. Is it still something people need ? If yes as Its a ton of time consuming. |
Just so you know. I have started a react 18 implementation of it. If you want to read more and support the project please take time to star the project or support via github sponsor. I will make sure to keep the readme updated |
For our use case, our team has been keeping a local fork of this repo updated to React 18. I'd like to start using the official package again and get this out of our monorepo. Would be happy to take some time to fix the knobs + add the updates by this weekend. This library is integral to us, so I figure I can give back a little here. |
@Amethystix I have migrate everything into react 18 syntax here https://github.com/flozero/react-18-chime-js-sdk You can install the package react-18-chime-js-sdk. I am finishing integrating this in my personal project and will offer this project to take backt he ownership if someone end up answering :) |
Thank you for your efforts in upgrading the library @Amethystix and @flozero and very sorry for delay in response to this. Currently, we are looking into the changes and working on a migration plan. If you have done significant work on knobs as well as all components we would appreciate if you could share the links, we would be happy to include your contributions as well as consider them as we plan to migrate. Unfortunately, we still do not have a final plan and date to address this, we will communicate so once we have it. |
Thanks for answering @devalevenkatesh . So far my repo have eveyrthing migrate into react 18 that include:
I found some potential issues that need to be investigate like background blur. But as we don't have the full plan from the aws chime I would guess its probably related to this. I didn't add back the storyblok preview. But it something I can do. Would be happy to discuss with you more and show you the work if you are interested. |
Hi there, we wanted to give you an update on our react 18 support. We have recently updated our SDK to support React 18 in the Before we officially release this change, we would love to receive your feedback on this update. We appreciate any comments or suggestions you may have. If you would like to give it a try, here're the steps:
Thank you for your support and patience! |
Hi all, we just published I'll close this issue for now, let us know if you run into any issue. |
What happened and what did you expect to happen?
After upgrading to React 18 in my Typescript project, I experienced several type related issues. This is because of the decision of the React team to remove implicit children (see DefinitelyTyped/DefinitelyTyped#56210).
There is a codemode provided which basically wraps all the props with
React.PropsWithChildren<YourProps>
which could come in handy for you.Have you reviewed our existing documentation?
Reproduction steps
Amazon Chime SDK React Components Library version
3.0.0
What browsers are you seeing the problem on?
N/A
Browser version
N/A
Device Information
N/A
Meeting and Attendee ID Information.
No response
Browser console logs
N/A
Add any other context about the problem here.
No response
The text was updated successfully, but these errors were encountered: