[Integration test] Update integration test server and add attendee presence timeout to audio, video test only #1196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, some canary runs are failing with the error: Unable to create meeting, server error: Error: Request failed with status code 403 This is due to the incorrect handling of baseURL in the integration server. This fix handles the query params if any and accordingly generates the create meeting URL. This also changes wait time in the AppWaitTestStep to be 1000ms from 100ms.
michhyun1
reviewed
Apr 13, 2021
devalevenkatesh
changed the title
devalevenkatesh
force-pushed
the
fix-integ-server
branch
from
90988c5
to
e9c5439
Compare
michhyun1
reviewed
Apr 14, 2021
| @@ -20,6 +20,10 @@ class SdkBaseTest extends KiteBaseTest { | |||
| this.userArn = this.payload.userArn; | |||
| } | |||
|
|
|||
| if (['Video', 'Audio'].includes(testName)) { | |||
There was a problem hiding this comment.
Just double checking - this is not backwards? Will 'testname' be Video or Audio?
There was a problem hiding this comment.
Just checked - our Audio and Video E2E test use the name "Audio" and "Video". Thanks
michhyun1
approved these changes
Apr 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #:
The current demo URL is (incorrect URL hence error from server):
After this fix it will be:
Description of changes:
integration/js/server.jschange can be reverted because we reverted the query parameter on the gamma demo URL, but it will catch such cases where we add any other query parameter to demo URLs and run test against it.Testing
npm run build:releaselocally? Yes.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.