Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transcribe data model update #1634

Merged
merged 2 commits into from Nov 19, 2021
Merged

Transcribe data model update #1634

merged 2 commits into from Nov 19, 2021

Conversation

akashuc
Copy link
Contributor

@akashuc akashuc commented Sep 30, 2021

Issue #:

Description of changes: Update transcribe data model on CHIME-JS-SDK. The changes include introducing PII entities and stabilization factor. This change also include adding fields to the protobuf model and adding decoding logic for the entity received.

Testing:

Can these tested using a demo application? Please provide reproducible step-by-step instructions.
Yes MeetingV2 can be used to test this changes as well regression testing. The changes have been tested in gamma using the demo app.

Regression can be performed on the changes:

  1. Use meetingV2 demo app
  2. Start and join the meeting
  3. Enable Live Transcription
  4. Transcript should start coming as earlier.

Checklist:

  1. Have you successfully run npm run build:release locally? yes

  2. Do you add, modify, or delete public API definitions? If yes, has that been reviewed and approved? no

  3. Do you change the wire protocol, e.g. the request method? If yes, has that been reviewed and approved?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@akashuc akashuc requested a review from haifengx October 1, 2021 00:09
CHANGELOG.md Outdated Show resolved Hide resolved
@akashuc akashuc force-pushed the TranscribeDataModelUp branch 2 times, most recently from f5af00f to 43d393b Compare October 4, 2021 06:06
protocol/SignalingProtocol.proto Outdated Show resolved Hide resolved
protocol/SignalingProtocol.proto Show resolved Hide resolved
protocol/SignalingProtocol.proto Show resolved Hide resolved
src/transcript/TranscriptEntity.ts Show resolved Hide resolved
src/transcript/TranscriptEvent.ts Outdated Show resolved Hide resolved
src/transcript/TranscriptEvent.ts Outdated Show resolved Hide resolved
src/transcript/TranscriptEvent.ts Show resolved Hide resolved
src/transcript/TranscriptEvent.ts Show resolved Hide resolved
test/transcript/TranscriptEventTestDataHelper.ts Outdated Show resolved Hide resolved
@akashuc akashuc changed the title Transcribe data model update [DO NOT MERGE] Transcribe data model update Oct 5, 2021
@akashuc akashuc force-pushed the TranscribeDataModelUp branch 2 times, most recently from 5f1a735 to 27d8e21 Compare November 2, 2021 02:55
demos/browser/app/meetingV2/meetingV2.ts Outdated Show resolved Hide resolved
demos/browser/app/meetingV2/meetingV2.ts Outdated Show resolved Hide resolved
demos/browser/app/meetingV2/meetingV2.ts Outdated Show resolved Hide resolved
demos/browser/app/meetingV2/meetingV2.ts Outdated Show resolved Hide resolved
demos/browser/app/meetingV2/meetingV2.ts Outdated Show resolved Hide resolved
src/transcript/TranscriptEvent.ts Outdated Show resolved Hide resolved
src/transcript/TranscriptEvent.ts Outdated Show resolved Hide resolved
test/transcript/TranscriptEvent.test.ts Show resolved Hide resolved
test/transcript/TranscriptEventTestDataHelper.ts Outdated Show resolved Hide resolved
test/transcript/TranscriptEventTestDataHelper.ts Outdated Show resolved Hide resolved
@akashuc akashuc requested a review from a team as a code owner November 10, 2021 00:02
protocol/SignalingProtocol.proto Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
demos/browser/app/meetingV2/meetingV2.ts Outdated Show resolved Hide resolved
demos/browser/app/meetingV2/meetingV2.ts Outdated Show resolved Hide resolved
demos/browser/app/meetingV2/meetingV2.ts Outdated Show resolved Hide resolved
demos/browser/app/meetingV2/meetingV2.ts Outdated Show resolved Hide resolved
demos/browser/server.js Outdated Show resolved Hide resolved
demos/browser/server.js Outdated Show resolved Hide resolved
@akashuc akashuc force-pushed the TranscribeDataModelUp branch 2 times, most recently from f1206a7 to 0a6f73b Compare November 10, 2021 05:20
haifengx
haifengx previously approved these changes Nov 12, 2021
Copy link
Contributor

@haifengx haifengx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

demos/browser/app/meetingV2/meetingV2.ts Outdated Show resolved Hide resolved
haifengx
haifengx previously approved these changes Nov 12, 2021
Copy link
Contributor

@richnew10 richnew10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs some thought to be given to the experience of a developer encountering this for the first time. Both developer docs (via block comments and included examples) and TypeScript help need attention.

demos/browser/app/meetingV2/meetingV2.ts Outdated Show resolved Hide resolved
demos/browser/app/meetingV2/meetingV2.ts Outdated Show resolved Hide resolved
demos/browser/app/meetingV2/meetingV2.ts Outdated Show resolved Hide resolved
demos/browser/app/meetingV2/meetingV2.ts Outdated Show resolved Hide resolved
demos/browser/app/meetingV2/meetingV2.ts Outdated Show resolved Hide resolved
protocol/SignalingProtocol.proto Show resolved Hide resolved
src/transcript/TranscriptEvent.ts Show resolved Hide resolved
src/transcript/TranscriptEntity.ts Show resolved Hide resolved
src/signalingprotocol/SignalingProtocol.d.ts Show resolved Hide resolved
src/signalingprotocol/SignalingProtocol.d.ts Show resolved Hide resolved
noahmako
noahmako previously approved these changes Nov 17, 2021
noahmako
noahmako previously approved these changes Nov 17, 2021
haifengx
haifengx previously approved these changes Nov 17, 2021
@akashuc akashuc dismissed stale reviews from haifengx and noahmako via a1d3e05 November 18, 2021 01:39
@akashuc akashuc force-pushed the TranscribeDataModelUp branch 2 times, most recently from a1d3e05 to 48eca4a Compare November 18, 2021 01:44
richnew10
richnew10 previously approved these changes Nov 18, 2021
demos/browser/app/meetingV2/meetingV2.ts Show resolved Hide resolved
@akashuc akashuc changed the title [DO NOT MERGE] Transcribe data model update Transcribe data model update Nov 18, 2021
…ntent identification and redaction, partial results stabilization, and custom language models for Amazon Transcribe and PHI content identification for Amazon Transcribe Medical
@akashuc akashuc requested a review from a team as a code owner November 18, 2021 23:51
@akashuc akashuc merged commit e821386 into master Nov 19, 2021
@akashuc akashuc deleted the TranscribeDataModelUp branch November 19, 2021 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants