New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transcribe data model update #1634
Conversation
f5af00f
to
43d393b
Compare
5f1a735
to
27d8e21
Compare
f1206a7
to
0a6f73b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs some thought to be given to the experience of a developer encountering this for the first time. Both developer docs (via block comments and included examples) and TypeScript help need attention.
a1d3e05
to
48eca4a
Compare
48eca4a
to
4a1a3a1
Compare
…ntent identification and redaction, partial results stabilization, and custom language models for Amazon Transcribe and PHI content identification for Amazon Transcribe Medical
4a1a3a1
to
f59d894
Compare
Issue #:
Description of changes: Update transcribe data model on CHIME-JS-SDK. The changes include introducing PII entities and stabilization factor. This change also include adding fields to the protobuf model and adding decoding logic for the entity received.
Testing:
Can these tested using a demo application? Please provide reproducible step-by-step instructions.
Yes MeetingV2 can be used to test this changes as well regression testing. The changes have been tested in gamma using the demo app.
Regression can be performed on the changes:
Checklist:
Have you successfully run
npm run build:release
locally? yesDo you add, modify, or delete public API definitions? If yes, has that been reviewed and approved? no
Do you change the wire protocol, e.g. the request method? If yes, has that been reviewed and approved?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.