Refactor some video demo components into classes, seperate files #1769
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #: None
Description of changes: I was scrolling through meetingV2.ts and sprained my finger, so figured it would be helpful to break this up. I'm not of the opinion that there is too much in this demo, but do think that in it's current form I wouldn't be super comfortable telling builders to just copy paste it as a start. Its also a bit of a headache if you are just looking to see how one component was integrated.
So as a start this breaks out some video related components into their own classes, and moves them to their own files as well. I can see the same being done for local video/audio configuration, and the chat messages.
Testing:
Smoke tested audio/video send and receive in a 3 attendee call.verified active speaker works. verified correct stats overlays. verified pause, and video preference setting worked as expected.
Can these tested using a demo application? Please provide reproducible step-by-step instructions.
There is no feature here. Regression testing should suffice.
Checklist:
Have you successfully run
npm run build:release
locally?y
Do you add, modify, or delete public API definitions? If yes, has that been reviewed and approved?
n
Do you change the wire protocol, e.g. the request method? If yes, has that been reviewed and approved?
n
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.