Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CODEOWNERS file #1770

Merged
merged 1 commit into from Nov 9, 2021
Merged

Add CODEOWNERS file #1770

merged 1 commit into from Nov 9, 2021

Conversation

devalevenkatesh
Copy link
Contributor

@devalevenkatesh devalevenkatesh commented Nov 9, 2021

Issue #:

Description of changes:

  • Adds CODEOWNERS file for branch protection and repository write access.
  • Added @aws/amazon-chime-sdk team as the owner.

Testing:

Can these tested using a demo application? Please provide reproducible step-by-step instructions.

  • NA.

Checklist:

  1. Have you successfully run npm run build:release locally? NA.

  2. Do you add, modify, or delete public API definitions? If yes, has that been reviewed and approved?
    NA.

  3. Do you change the wire protocol, e.g. the request method? If yes, has that been reviewed and approved?
    NA.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jing-chen1
Copy link
Contributor

I am a little confused. In the PR description, it says "Added @aws/amazon-chime-mobile team", but in the code, it is @aws/amazon-chime-sdk

@devalevenkatesh
Copy link
Contributor Author

I am a little confused. In the PR description, it says "Added @aws/amazon-chime-mobile team", but in the code, it is @aws/amazon-chime-sdk

Yes, I realized that, I have corrected it, the tab changed to mobile team when GitHub suggest when I at mentioned.

@ltrung ltrung merged commit 0bcd7fb into master Nov 9, 2021
@ltrung ltrung deleted the add-codeowners branch November 9, 2021 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants