Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Background Blur integration test #1772

Merged
merged 2 commits into from Nov 10, 2021
Merged

Fix Background Blur integration test #1772

merged 2 commits into from Nov 10, 2021

Conversation

pkrupali
Copy link
Contributor

@pkrupali pkrupali commented Nov 9, 2021

Issue #:
We're seeing intermittent failures for background blur integration tests on sauce labs.

For some of the failed tests, it looks like once the video is enabled, currently it checks if background blur is working even before the video could actually turn on, and due to this timing issue sometimes test fails too soon.

Description of changes:

To avoid this issue,

  • After enabling video and background blur, I added a check to see if local video is turned on
  • Once video is on, we'll then continuously check if background is blurred for a maximum of ten times(with 1s wait period).

Testing:

Can these tested using a demo application? Please provide reproducible step-by-step instructions.
Yes,

  1. Add a sample test video with name test_videounder integration/js folder
  2. Modify directory value in config file to "directory":"",
  3. Follow the steps to run integration test locally.

Checklist:

  1. Have you successfully run npm run build:release locally?
    Yes

  2. Do you add, modify, or delete public API definitions? If yes, has that been reviewed and approved?
    No

  3. Do you change the wire protocol, e.g. the request method? If yes, has that been reviewed and approved?
    No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@pkrupali pkrupali requested a review from a team as a code owner November 9, 2021 23:05
@ltrung ltrung merged commit 42dbfdf into master Nov 10, 2021
@ltrung ltrung deleted the bgblur-fix-canary branch November 10, 2021 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants