Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add delay and use meeting leave over end in event reporting test #1779

Merged
merged 1 commit into from Nov 10, 2021

Conversation

devalevenkatesh
Copy link
Contributor

Issue #:
Some event ingestion integration test runs might result into 403s:

  1. I am using EndMeetingStep instead of LeaveMeetingStep. When a meeting is ended the ingestion service invalidates the authorization token cache and hence any request reaching after this invalidation will result into a 403.
  2. The join and the roster check often completes very quickly in max 3-4s seconds and soon the End meeting step is triggered. Now according to logic for event ingestion from client side, we send the collected events at an interval of 5s by default. Thus, this explains why the request may have not got triggered and the test ends soon with also ending the meeting.
  3. The end meeting will move away from the meeting screen so this should also still send the POST request using sendBeacon but since the authorization token itself may have been invalidated those request might result in 403.

Description of changes:
To address this I am making below changes to the existing test:

  1. Use LeaveMeeting over EndMeeting step.
  2. Add a delay of 5s before leaving the meeting.

Testing:

  • Tested few runs on SauceLabs from local and checked on the ingestion service backend logs if events are appeared fine. Received all events as expected.

Can these tested using a demo application? Please provide reproducible step-by-step instructions.
NA.

Checklist:

  1. Have you successfully run npm run build:release locally?
    NA, integration test change.

  2. Do you add, modify, or delete public API definitions? If yes, has that been reviewed and approved?
    NA.

  3. Do you change the wire protocol, e.g. the request method? If yes, has that been reviewed and approved?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

1. I am using EndMeetingStep instead of LeaveMeetingStep. When a meeting is ended the ingestion service invalidates the authorization token cache and hence any request reaching after this invalidation will result into a 403.
2. The join and the roster check often completes very quickly in about 3-4s seconds and soon the End meeting step is triggered. Now according to logic for event ingestion from client side, we send the collected events at an interval of 5s. Thus, this explains why the request may have not got triggered and the test ends soon with also ending the meeting.
3. The end meeting will move away from the meeting screen so this should also still send the POST request using sendBeacon but since the authorization token itself may have been invalidated those request might result in 403.

To address this I am making below changes to the existing test:
1. Use LeaveMeeting over EndMeeting step.
2. Add a delay of 5s before leaving the meeting.
@devalevenkatesh devalevenkatesh requested a review from a team as a code owner November 10, 2021 22:09
@devalevenkatesh devalevenkatesh merged commit ce1aaae into master Nov 10, 2021
@devalevenkatesh devalevenkatesh deleted the update-event-reporting-test branch November 10, 2021 22:35
akashuc pushed a commit that referenced this pull request Nov 12, 2021
1. I am using EndMeetingStep instead of LeaveMeetingStep. When a meeting is ended the ingestion service invalidates the authorization token cache and hence any request reaching after this invalidation will result into a 403.
2. The join and the roster check often completes very quickly in about 3-4s seconds and soon the End meeting step is triggered. Now according to logic for event ingestion from client side, we send the collected events at an interval of 5s. Thus, this explains why the request may have not got triggered and the test ends soon with also ending the meeting.
3. The end meeting will move away from the meeting screen so this should also still send the POST request using sendBeacon but since the authorization token itself may have been invalidated those request might result in 403.

To address this I am making below changes to the existing test:
1. Use LeaveMeeting over EndMeeting step.
2. Add a delay of 5s before leaving the meeting.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants