Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Demo] Fix the demo to display thunderbolt when paused by policy #1780

Merged
merged 2 commits into from Nov 10, 2021

Conversation

ltrung
Copy link
Contributor

@ltrung ltrung commented Nov 10, 2021

Description of changes:
Fix the current demo to display thunderbolt sign when video tiles are paused by priority downlink policy.
Testing:

Can these tested using a demo application? Please provide reproducible step-by-step instructions.

  • Join a meeting with priority-based downlink policy with several videos
  • Use Network link conditioner to throttle the network
  • Verify that you can see the thunderbolt sign

Checklist:

  1. Have you successfully run npm run build:release locally? N/A

  2. Do you add, modify, or delete public API definitions? If yes, has that been reviewed and approved? N/A

  3. Do you change the wire protocol, e.g. the request method? If yes, has that been reviewed and approved? N/A

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ltrung ltrung requested a review from a team as a code owner November 10, 2021 23:20
Copy link
Contributor

@hensmi-amazon hensmi-amazon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:D

@ltrung ltrung merged commit 1c1ec7c into master Nov 10, 2021
@ltrung ltrung deleted the fix-demo-thunderbolt branch November 10, 2021 23:49
xuesichao pushed a commit that referenced this pull request Nov 11, 2021
Co-authored-by: Venkatesh Devale <61809205+devalevenkatesh@users.noreply.github.com>
akashuc pushed a commit that referenced this pull request Nov 12, 2021
Co-authored-by: Venkatesh Devale <61809205+devalevenkatesh@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants