Fix priority downlink policy bandwidth estimation metrics to work with Safari #1783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ltrung
force-pushed
the
update-metric-priority
branch
from
959c10e
to
1224701
Compare
| @@ -191,23 +192,23 @@ export default class VideoPriorityBasedPolicy implements VideoDownlinkBandwidthP | |||
| this.prevDownlinkStats = this.downlinkStats; | |||
| this.downlinkStats = new LinkMediaStats(); | |||
| const metricReport = clientMetricReport.getObservableMetrics(); | |||
| this.downlinkStats.bandwidthEstimateKbps = metricReport.availableReceiveBandwidth / 1000; | |||
| if (!isNaN(metricReport.availableOutgoingBitrate)) { | |||
ltrung
force-pushed
the
update-metric-priority
branch
from
1224701
to
993a5cf
Compare
hensmi-amazon
previously approved these changes
Nov 11, 2021
| @@ -191,23 +192,23 @@ export default class VideoPriorityBasedPolicy implements VideoDownlinkBandwidthP | |||
| this.prevDownlinkStats = this.downlinkStats; | |||
| this.downlinkStats = new LinkMediaStats(); | |||
| const metricReport = clientMetricReport.getObservableMetrics(); | |||
| this.downlinkStats.bandwidthEstimateKbps = metricReport.availableReceiveBandwidth / 1000; | |||
| if (!isNaN(metricReport.availableOutgoingBitrate)) { | |||
ltrung
force-pushed
the
update-metric-priority
branch
from
993a5cf
to
cf7b805
Compare
hensmi-amazon
approved these changes
Nov 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #:
The current priority-based downlink policy uses webRTC's available downlink bandwidth estimate to calculate whether it should pause video tiles to reserve bandwidth. However, the current implementation only checks stats from Chrome and not from other browser.
Description of changes:
Update to read stats from Safari. Firefox did not support
availableOutgoingBitrateat this point so update the guide to clarify that instead.Testing:
Test priority-based downlink policy and check the bandwidth estimate to be correct (previously it is always null).
Can these tested using a demo application? Please provide reproducible step-by-step instructions.
Checklist:
Have you successfully run
npm run build:releaselocally? YesDo you add, modify, or delete public API definitions? If yes, has that been reviewed and approved? No
Do you change the wire protocol, e.g. the request method? If yes, has that been reviewed and approved? No
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.