Fix demo button camera toggle to retain existing screen selection #1820
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #:
Camera option selected from Device selection page is retained in
the meeting whenever video turned off and on in JS SDK meetingV2 demo.
When we toggle the button camera we choose the video input device value
from the select box which is not in the in-meeting screen rather it is
in the preview device selection screen.
The button-camera button is on the in-meeting screen and hence since it
is selecting "video-input" (preview video input HTML select box) value
it is picking and retaining what you select on the preview screen and
not retaining in-meeting screen selection.
Description of changes:
Fix is to use stored selected video input over using video input from
preview device selection page.
Testing:
Can these tested using a demo application? Please provide reproducible step-by-step instructions.
meetingV2
Checklist:
Have you successfully run
npm run build:release
locally?Demo change.
Do you add, modify, or delete public API definitions? If yes, has that been reviewed and approved?
NA
Do you change the wire protocol, e.g. the request method? If yes, has that been reviewed and approved?
NA
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.