Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump protobufjs from 6.11.3 to 7.2.4 #2705

Merged
merged 1 commit into from
Jul 13, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,13 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Changed

- Added recommendations to use server side network adaptation, and clarified support on all browsers. Removed demo features and information on network adaptation configuration that is not used when server side network adaptation is used.
- Set `esModuleInterop` to `true` in tsconfig.json, and update several import statements.

### Fixed

- Bump protobufjs from 6.11.3 to 7.2.4.
- Fixed usage of `this` in `VideoCodecCapability` constructors.
- Fixed a race condition error if calling `startContentShare` then `stopContentShare` right after.
- Fixed a race condition error if calling `startContentShare` then `stopContentShare` right after.

## [3.15.0] - 2023-05-01

Expand All @@ -47,7 +49,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Removed

### Changed
- Update chime sdk messaging client version

- Update chime sdk messaging client version.

### Fixed

Expand Down Expand Up @@ -147,7 +150,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Fixed

- Fixed missing videos, or unnecessarily long freezes when switching simulcast streams.
- Fixed missing videos, or unnecessarily long freezes when switching simulcast streams.

## [3.8.0] - 2022-08-18

Expand All @@ -165,7 +168,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Fixed

- `MessagingSession` reconnect loop did not break on error past reconnect deadline. Infinite reconnect loop was caused due to `firstConnectionAttemptTimestamp` not being set as `startedConnectionAttempt` was not invoked. Check https://github.com/aws/amazon-chime-sdk-js/issues/2372 for details.
- `MessagingSession` reconnect loop did not break on error past reconnect deadline. Infinite reconnect loop was caused due to `firstConnectionAttemptTimestamp` not being set as `startedConnectionAttempt` was not invoked. Check <https://github.com/aws/amazon-chime-sdk-js/issues/2372> for details.
- `MessagingSession` `getMessagingSessionEndpoint` call is now backwards compatible with AWS JS SDK v2.
- Use a default "playback" `latencyHint` when creating the `AudioContext` on Windows. Also adds a `setDefaultLatencyHint` API to `DefaultDeviceController` to allow for overriding.
- Fix behavior of websocket disconnects before a session is connected. Session.start() promise shall fail in the scenario.
Expand Down Expand Up @@ -208,13 +211,14 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Changed

### Fixed

- Fix issue closing a web worker in Amazon Voice Focus's inline worklet.

## [3.5.0] - 2022-06-02

### Added

- Add a workaround for https://bugs.webkit.org/show_bug.cgi?id=241152 to play a paused video element in Safari.
- Add a workaround for <https://bugs.webkit.org/show_bug.cgi?id=241152> to play a paused video element in Safari.

### Removed

Expand Down Expand Up @@ -255,6 +259,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
## [3.3.0] - 2022-05-12

### Added

- Add support for hosting meetings in US GovCloud regions.
- Add support for starting live transcription in US GovCloud regions.

Expand Down
3 changes: 2 additions & 1 deletion config/tsconfig.base.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
"noUnusedLocals": true,
"sourceMap": true,
"stripInternal": true,
"target": "ES2015"
"target": "ES2015",
"esModuleInterop": true
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

protobufjs@7.2.4 requires long@5.0.0 which is a esm now, we need to enable this rule to import it properly.
dcodeIO/long.js@8641039

}
}
117 changes: 62 additions & 55 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -65,14 +65,14 @@
},
"devDependencies": {
"@fluffy-spoon/substitute": "^1.89.0",
"@types/chai": "^4.1.7",
"@types/chai": "^4.3.5",
"@types/chai-as-promised": "^7.1.0",
"@types/mocha": "^5.2.6",
"@types/sinon": "^7.0.12",
"@types/uuid": "^8.3.1",
"@typescript-eslint/eslint-plugin": "^4.18.0",
"@typescript-eslint/parser": "^4.18.0",
"chai": "^4.2.0",
"chai": "^4.3.7",
"chai-as-promised": "^7.1.1",
"cross-env": "^6.0.3",
"eslint": "^7.22.0",
Expand Down Expand Up @@ -103,7 +103,7 @@
"@types/ua-parser-js": "^0.7.35",
"detect-browser": "^5.2.0",
"pako": "^2.0.4",
"protobufjs": "^6.11.3",
"protobufjs": "^7.2.4",
"resize-observer": "^1.0.0",
"ua-parser-js": "^1.0.1"
},
Expand Down
2 changes: 1 addition & 1 deletion src/signalingprotocol/SignalingProtocol.d.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import * as Long from "long";
import Long from "long";
import * as $protobuf from "protobufjs";
/** Properties of a SdkSignalFrame. */
export interface ISdkSignalFrame {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
// SPDX-License-Identifier: Apache-2.0

import * as chai from 'chai';
import * as chaiAsPromised from 'chai-as-promised';
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also need to update this to fix unit tests after enabling esModuleInterop

import chaiAsPromised from 'chai-as-promised';
import * as sinon from 'sinon';

import {
Expand Down
2 changes: 1 addition & 1 deletion test/backgroundprocessor/BackgroundBlurProcessor.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
// SPDX-License-Identifier: Apache-2.0

import * as chai from 'chai';
import * as chaiAsPromised from 'chai-as-promised';
import chaiAsPromised from 'chai-as-promised';
import * as sinon from 'sinon';

import * as loader from '../../libs/voicefocus/loader';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
// SPDX-License-Identifier: Apache-2.0

import * as chai from 'chai';
import * as chaiAsPromised from 'chai-as-promised';
import chaiAsPromised from 'chai-as-promised';
import * as sinon from 'sinon';

import { BackgroundFilterSpec, BackgroundReplacementOptions } from '../../src';
Expand Down
Loading
Loading