Add alternative for audio device switching and add flag to disable the use of WebAudio #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Typo in commit message: "Add flag to disbale webaudio" |
XHatan
changed the title
andibrae-amzn
previously approved these changes
Dec 17, 2019
| /** | ||
| * Feature flag to enable WebAudio processing | ||
| */ | ||
| enableWebAudio: boolean = true; |
There was a problem hiding this comment.
I think we should set this to false by default so that it's opt-in rather than opt-out.
|
I haven't seen the Travis build fail with that error before. Any idea what's going with that? |
I noticed when I built it locally, after all tests passed showing |
|
Typo in commit message "disbale" instead of "disable". |
…sable the use of WebAudio
andibrae-amzn
approved these changes
Dec 17, 2019
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #:
Description of changes
We use
WebAudioinDefaultDeviceControllerfor audio stream/track management. It poses some problem: for example, in Safari, audio will stop when apps running in background.This PR provides an alternative implementation where we use audio stream directly.
When switching device,
replaceTrackis used in RTCRtpSender to avoid rejoining meeting since triggering a re-subscription violates certain server assumptions.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.