Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve reconnect callback fidelity #52

Merged
merged 1 commit into from
Jan 2, 2020
Merged

Conversation

agowatch
Copy link
Contributor

Issue #:

Description of changes

Improves callback fidelity in reconnect scenarios:

  • ensure open event is dispatched when a websocket reconnects
  • ensure close event is dispatched if reconnect eventually fails

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@agowatch agowatch force-pushed the bug/reconnect-callbacks branch 2 times, most recently from af7bb4d to 03b841f Compare January 2, 2020 19:10
simmkyu
simmkyu previously approved these changes Jan 2, 2020
@simmkyu simmkyu merged commit ecc4f01 into master Jan 2, 2020
@simmkyu simmkyu deleted the bug/reconnect-callbacks branch January 2, 2020 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants