Adding GPU E2E Test #171
Closed
Adding GPU E2E Test #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
musa-asad
previously approved these changes
May 9, 2024
movence
reviewed
May 10, 2024
| go test ${var.test_dir} -eksClusterName ${aws_eks_cluster.this.name} -computeType=EKS -v -eksDeploymentStrategy=DAEMON -eksGpuType=nvidia | ||
|
|
||
| # Get all pods and describe them | ||
| kubectl get pods --all-namespaces -o wide > pods.txt |
There was a problem hiding this comment.
why do you need to write it to a file?
| "github.com/aws/amazon-cloudwatch-agent-test/test/test_runner" | ||
| ) | ||
|
|
||
| type GPUTestSuite struct { |
There was a problem hiding this comment.
As we discussed, you don't need a test suite for this e2e test. The purpose of test suite is to group similar tests into a group to execute them all in the suite. There is no other test will be added to this suite. Other accelerated compute instance types (eg tranium) will be its own test with a different instance type in terraform file that will execute a different test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Currently there is an integration test for GPU, but we need an e2e test for this.
Description of changes:
The main difference between integration test and this is that we install the eks addon instead of mocking the dcgm exporter and daemonsets/services.
Steps happening in the e2e
E2E Test
https://github.com/aws/amazon-cloudwatch-agent-operator/actions/runs/9033457562
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.