build: Build docker without open telemetry collector #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pingleig
added
area/build
|
Note that this produces dynamically linked arm64 binaries (which ultimately fail to execute because the container doesn't contain the required libraries). Adding |
|
Actually things has been working fine (for our internal build) because we are not using dockerized build . We build arm64 binary on x86_64 host using cross compile, and cgo is is disabled by default when cross-compiling But we should set it explicitly. |
pingleig
added a commit
to pingleig/amazon-cloudwatch-agent
that referenced
this pull request
Jun 18, 2021
From aws#228 (comment) We were assuming the arm binary is build on x86 using cross compile. This is case for our internal build and has been working fine for arm docker image, but if user build the binary on arm machines, then cgo is enabled and the binary no longer runs in scratch container.
pingleig
added a commit
that referenced
this pull request
Jun 18, 2021
From #228 (comment) We were assuming the arm binary is build on x86 using cross compile. This is case for our internal build and has been working fine for arm docker image, but if user build the binary on arm machines, then cgo is enabled and the binary no longer runs in scratch container.
|
Fixed the arm cgo problem in #235 |
pxaws
approved these changes
Jun 19, 2021
sky333999
pushed a commit
that referenced
this pull request
Jul 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue
We were using deb when building image from source, i.e. source -> deb -> docker image. But we have composite agent, which is not used when running as image.
Description of changes
DockerfileLicense
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Tests
Run the new commands (in a place that does not block go mod proxy)