Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Process exits immediately when cannot reach CloudWatch logs endpoint. #18

Closed
kiranmeduri opened this issue Oct 3, 2019 · 2 comments
Closed
Labels
bug Something isn't working

Comments

@kiranmeduri
Copy link

In the context of service-mesh setups like App Mesh, task or pod network is not ready to send external traffic until Envoy proxy is ready. This results in connect failures. Container launch ordering should probably work (could not find in documentation), but it is not currently possible in Kubernetes environment.

To address, I would recommend this process to retry before giving up.

@PettitWesley PettitWesley added the bug Something isn't working label Oct 4, 2019
@PettitWesley
Copy link
Contributor

PettitWesley commented Oct 4, 2019

Labelling this as a bug because it was not intended and it breaks workflows.

This happens because we try to create the log group when initializing the plugin. See here, and here.

Instead, we should do something like set a boolean on the OutputPlugin struct to track whether or not the log group has been created. Creation can be handled in AddEvent() and Flush()- if creation is unsuccessful we can return an FLB_RETRY. Then Fluent Bit will not quit, and the creation and sending will be retried.

@kiranmeduri
Copy link
Author

PettitWesley added a commit to PettitWesley/amazon-cloudwatch-logs-for-fluent-bit that referenced this issue Oct 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants