Adding endpoint_credentials param and changed Slice to SliceStable for sorting. #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cloudwatch/cloudwatch.go
Outdated
| @@ -165,6 +167,14 @@ func newCloudWatchLogsClient(roleARN string, sess *session.Session, endpoint str | |||
| } | |||
| svcConfig.EndpointResolver = endpoints.ResolverFunc(cwCustomResolverFn) | |||
| } | |||
| if credsEndpoint != "" { | |||
| logrus.Infof("Trying to get credentials from credentials_endpoint %s", credsEndpoint) | |||
There was a problem hiding this comment.
This info statement is redundant since you already print it when you read the parameter.
There was a problem hiding this comment.
Yeah, makes sense. will remove it
fluent-bit-cloudwatch.go
Outdated
| @@ -83,6 +83,8 @@ func getConfiguration(ctx unsafe.Pointer, pluginID int) cloudwatch.OutputPluginC | |||
| logrus.Infof("[cloudwatch %d] plugin parameter auto_create_group = '%v'\n", pluginID, config.AutoCreateGroup) | |||
| config.CWEndpoint = output.FLBPluginConfigKey(ctx, "endpoint") | |||
| logrus.Infof("[cloudwatch %d] plugin parameter endpoint = '%s'\n", pluginID, config.CWEndpoint) | |||
| config.CredsEndpoint = output.FLBPluginConfigKey(ctx, "credentials_endpoint") | |||
| logrus.Info("[cloudwatch %d] plugin parameter credentials_endpoint = %s\n", pluginID, config.CredsEndpoint) | |||
There was a problem hiding this comment.
Thanks!
Will make both the changes and create a new revision
|
Ran the cloudwatch integ tests; they passed. |
PettitWesley
approved these changes
Dec 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.