Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding "Sorting" in the table-wide Mode #21

Closed
4pits opened this issue Jul 8, 2020 · 2 comments
Closed

Adding "Sorting" in the table-wide Mode #21

4pits opened this issue Jul 8, 2020 · 2 comments
Labels
enhancement New feature or request

Comments

@4pits
Copy link

4pits commented Jul 8, 2020

This is no doubt a cool addition to our toolset. Right now output is sorted by "Instance Type"
Requesting Add feature like "Sort By" in the Table Wide mode.
Can we add Sorting to sort by other variables ?

Something like

ec2-instance-selector --gpus 1 -o table-wide --sort m

_

@bwagner5 bwagner5 added the enhancement New feature or request label Jul 20, 2020
@bwagner5
Copy link
Contributor

@4pits sorry for the delayed reply! I definitely think it would be helpful to add sorting. I'm wondering if the sort would also apply to the regular output as well. One of the reasons it is sorted by instance-type is to make sure the response is deterministic between runs since the max-results is, by default, 20. Since the behind the scenes calls to the EC2 DescribeInstanceTypes API are paged, we needed a way to make sure results were consistent.

@digocorbellini
Copy link
Contributor

@4pits Instance type sorting has now been implemented for all output formats! Checkout the readme for an example of its use: CLI Examples

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants