Fixed interactive table resizing bug #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Previously, if you resized the terminal so that its height was less than the height of the table footer and header combined, a visual bug would occur where both the header and footer would disappear and there would be two highlighted rows. This is shown in the image below:
Now, if the terminal height is less than the height of the table footer and header combined, both the header and footer will be disabled and only 1 row will be visible. This prevents the visual bug from occurring while also leaving space for the filtering text to appear. The new format is shown below:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.