New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add kernel, ramdisk, network-index paths #119

Merged

brycahta merged 1 commit into aws:main from brycahta:path-me-bb

Feb 10, 2021

Contributor

brycahta commented Feb 9, 2021

Issue #, if available:

N/A

Description of changes:

Adding more IMDS paths:
kernel-id
ramdisk-id
network/interfaces/macs/mac/network-card-index

Why not support those Windows paths?

According to aws docs, all Windows IMDS paths return as plaintext which is already one difference between the platforms
Querying this path /latest/meta-data/elastic-gpus/associations is only valid on Windows and returns the following (as plaintext):

version    elasticGpuId                          elasticGpuType connectionConfig
-------    ------------                          -------------- ----------------
2016-11-30 egpu-4faa05b30e3c47a0a1d4e124d58af411 eg1.medium     @{connectionType=network; ipv4Address=172.31.18.68; ...

I don't think converting this to JSON or returning as-is is helpful when it comes to using AEMM to mock behavior

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.


          add kernel, ramdisk, network-index paths

d808d90

brycahta requested a review from cjerad

February 9, 2021 23:11

cjerad approved these changes

View reviewed changes

brycahta merged commit efec23a into aws:main

brycahta deleted the path-me-bb branch

February 10, 2021 16:38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment