Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Windows build #143

Merged
merged 3 commits into from
Sep 1, 2021
Merged

Improve Windows build #143

merged 3 commits into from
Sep 1, 2021

Conversation

brycahta
Copy link
Contributor

@brycahta brycahta commented Sep 1, 2021

Issue #, if available:

  • N/A

Description of changes:

  • embed the version so we can simplify the build process. Now, we won't need to rely on make to get aemm compiled properly and can use go build directly.
  • the github action Windows runner comes with make on it already, so can remove.
  • updated validators and other release scripts to maintain version.txt

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@bwagner5 bwagner5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants